Repository navigation
Conversation
A blank line between two blocks of a list item makes the list loose. The blank line was only taken into account if it came after a paragraph or nested list item, so it was missed after an HTML block, an indented code block or a setext heading. And a blank line between two blocks of a nested item also made the outer list loose if the outer item got another block later. Instead, check whether the line before a new block in the item was blank, like commonmark.js and cmark do.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A blank line between two blocks of a list item should make the list loose, but
ListItemParseronly counted the blank line if the active block was a paragraph or a list item. So these rendered as tight lists (no<p>aroundbar):The other way around, a blank line between two blocks of a nested item also made the outer list loose if the outer item got another block later:
Here the outer list should stay tight (
<li>a).The fix checks whether the line before a new block in the item was blank instead of looking at the active block. That matches commonmark.js and cmark, which check for a gap between consecutive children (
endsWithBlankLine), and blank lines inside a code block that continues afterwards still don't count.Tests added in
ListTightLooseTest: the four cases above fail without the change, andtightListWithIndentedCodeBlockguards the blank-line-inside-code case. Expected output is what cmark 0.31.2 and commonmark.js 0.31.2 produce.mvn test(all modules) andmvn spotless:checkpass.