Skip to content

Fixing missing username + date object on saved page - #922

Merged
NiallJoeMaher merged 2 commits into
codu-code:developfrom
NiallJoeMaher:bugfix/fix-username-missing-in-session-bugs
Apr 26, 2024
Merged

Fixing missing username + date object on saved page#922
NiallJoeMaher merged 2 commits into
codu-code:developfrom
NiallJoeMaher:bugfix/fix-username-missing-in-session-bugs

Conversation

@NiallJoeMaher

@NiallJoeMaher NiallJoeMaher commented Apr 26, 2024 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

✨ Codu Pull Request 💻

Codu Logo

Pull Request details

  • Fix missing profile route from navigation
  • Fix broken saved items page
  • Remove some unused code

Any Breaking changes

  • None

Summary by CodeRabbit

  • New Features

    • Enhanced user data fetching to display username in the layout component.
    • Updated the Nav component to accept a username parameter for improved URL management.

  • Bug Fixes

    • Updated ownership comparison logic in the Page function to enhance security by comparing user IDs instead of usernames.
    • Improved date formatting in the SavedPosts component for consistency.

  • Refactor

    • Simplified the close function in the MobileNav interface to improve code clarity and maintainability.
    • Adjusted session handling in authentication to streamline user ID management.

  • Documentation

    • Updated function parameters and properties in components and server logic to align with new features and refactors.

@NiallJoeMaher
NiallJoeMaher requested a review from a team as a code owner April 26, 2024 20:46
@vercel

vercel Bot commented Apr 26, 2024

Copy link
Copy Markdown

@NiallJoeMaher is attempting to deploy a commit to the Codú Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Apr 26, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The updates bring significant improvements to user data handling and interface interactions in the application. These changes enhance security by updating how ownership is determined, streamline navigation properties, improve data formatting for display, simplify function parameters, and integrate username data more effectively into UI components. These enhancements ensure a smoother user experience and more robust data management.

Changes

Files Change Summary
.../[username]/page.tsx Updated ownership logic to compare user IDs instead of usernames.
.../layout.tsx Introduced new imports and logic for fetching user data based on session ID.
.../saved/_client.tsx Updated date formatting in SavedPosts component.
components/Nav/MobileNav.tsx Simplified close function in MobileNavProps.
components/Nav/Nav.tsx Added username parameter to Nav component props.
server/auth.ts Modified session callback to streamline user data handling.

🐰✨📜
A hop, a skip, a code deploy,
Changes abound, oh what a joy!
IDs match, and dates align,
Navigation smooth, all by design.
Cheers to the devs, with each line they refine! 🌟
🐇💻

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between cb322e9 and 0ec7ba1.
Files selected for processing (1)
  • server/auth.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • server/auth.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vercel

vercel Bot commented Apr 26, 2024 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
codu ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2024 8:58pm

@NiallJoeMaher
NiallJoeMaher merged commit 1c49c90 into codu-code:develop Apr 26, 2024
@NiallJoeMaher
NiallJoeMaher deleted the bugfix/fix-username-missing-in-session-bugs branch April 26, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@NiallJoeMaher