feat: allow external services to be authable#9996
Merged
Merged
Conversation
Member
Author
|
@bpmct please review the docs on this change. We also need to add a permanent redirect for coder.com from |
BrunoQuaresma
approved these changes
Oct 2, 2023
Contributor
BrunoQuaresma
left a comment
There was a problem hiding this comment.
FE code looks good but there are a few Storybook stories broken
Member
Author
|
Fixed! Good call on checking the Storybook. |
✔️ PR 9996 Updated successfully.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows external services to be authenticated with Coder via "Create Workspace".
Shortlist of changes:
CODER_GITAUTH_toCODER_EXTERNAL_AUTH_(this is backwards compatible).DISPLAY_NAMEandDISPLAY_ICONproperties.TYPE=oidcto enable any OpenID Connect provider to work with external auth.Future improvements:
coder external-auth refresh --type=github,coder external-auth refresh --id=github,coder external-auth refresh --match="https://github.com"coder_external_authTerraform data source to replacecoder_git_auth. Allow for matching based ontypeandregexso Modules can make use of auth 👀.