feat: failed update refresh should redirect to login#9442
Merged
Conversation
aslilac
approved these changes
Aug 30, 2023
Member
aslilac
left a comment
There was a problem hiding this comment.
This is a great little bit of cleanup 💕
deansheather
approved these changes
Aug 30, 2023
| if err != nil { | ||
| return write(http.StatusUnauthorized, codersdk.Response{ | ||
| Message: "Could not refresh expired Oauth token.", | ||
| Message: "Could not refresh expired Oauth token. Try re-authenticating to resolve this issue.", |
Member
There was a problem hiding this comment.
How will they reauthenticate other than manually wiping their cookies?
Member
There was a problem hiding this comment.
The frontend will intercept the "Unauthorized" status code and redirect to the login page. They shouldn't ever even see this message.
If they're using the CLI, they can just run coder login again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our redirect to login was not happening on all 401 errors. I corrected this on the FE and fixed 2 places where we should return a
ForbiddenvsUnauthorized.Closes https://github.com/coder/v2-customers/issues/280