fix: avoid redirect loop on workspace proxies#9389
Merged
Conversation
Emyrk
reviewed
Aug 28, 2023
Comment on lines
+106
to
+109
| if !strings.HasSuffix(req.BasePath, "/") { | ||
| req.BasePath += "/" | ||
| } | ||
|
|
Member
|
Veried on a local deployment and path based apps. |
Emyrk
approved these changes
Aug 29, 2023
Member
Emyrk
left a comment
There was a problem hiding this comment.
I just added tests to @deansheather's PR 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the old
coder_devurl_session_tokencookie to be two new cookies:coder_path_app_session_tokenandcoder_subdomain_app_session_token. This avoids cases where the cookie for botheurope.dev.coder.comand.europe.dev.coder.comare both sent to Coder, but we can only seteurope.dev.coder.comon path apps.Changes the signed app token generating and comparing code to always append
/to the base path to avoid generating two signed tokens when redirecting from/@user/workspace/apps/appto/@user/workspace/apps/app/(trailing slash redirect).We will also now try to validate up to 4 signed app token cookies in the request in case multiple cookies are specified by the browser. Browsers will send all cookies with the same name but different paths, not only a single one with the most specific path.
TODO:
Closes #9109