fix: don't navigate away from editor after publishing#9153
Merged
Conversation
aslilac
commented
Aug 17, 2023
Comment on lines
-220
to
-226
| title={ | ||
| dirty | ||
| ? "You have edited files! Run another build before updating." | ||
| : templateVersion.job.status !== "succeeded" | ||
| ? "Something" | ||
| : "" | ||
| } |
Member
Author
There was a problem hiding this comment.
I removed this because browsers disable title whenever the element they apply to is disabled. The only text that ever had a chance of being seen by a user was the "Something" placeholder text. 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7153
onPublishaction that was only used to navigate away from the editor after publishing