feat: add activity bumping to template scheduling#9040
Merged
Conversation
d3fda4e to
c1da2e0
Compare
BrunoQuaresma
approved these changes
Aug 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to update the
last_used_atand/orlocked_atfields for template workspaces when updating the template scheduling form. This is to prevent updates to theinactivity_ttlorlocked_ttlfields on a template having a potentially unintended effect for existing workspaces.e.g. You update the
locked_ttlfield to retain locked workspaces for 1 day from 10 days, inadvertently deleting workspaces that have already been locked for more than 1 day.