ci: use a wildcard subdomain for PR deployments#8801
Merged
Conversation
Member
Author
|
/deploy-pr --skip-build --experiments *, single_tailnet |
|
✔️ Deployed PR 8801 successfully. |
johnstcn
reviewed
Aug 1, 2023
johnstcn
reviewed
Aug 1, 2023
johnstcn
reviewed
Aug 1, 2023
johnstcn
approved these changes
Aug 1, 2023
johnstcn
left a comment
Member
There was a problem hiding this comment.
This looks fine to me, but we will need to be careful of LetsEncrypt rate limits. If we run into further issues we may need to look into using self-signed certificates.
Member
Author
|
The letsencrypt is 50 certs per domain per week. Now we have a different domain for each PR and are preserving the certificates by creating them in a shared namespace to avoid recreating them if one already exists. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wildcard apps now work as expected.
We were hitting letsencrypt rate limits for certs because of deleting and recreating certs with each deployment. I tried to fix that by creating certificates in a shared namespace and copying them to the PR namespace.