feat: add frontend for locked workspaces#8655
Merged
Merged
Conversation
- Fix workspaces query for locked workspaces.
| {/* <ImpendingDeletionBadge/> determines its own visibility */} | ||
| <Cond condition={Boolean(ImpendingDeletionBadge({ workspace }))}> | ||
| <ImpendingDeletionBadge workspace={workspace} /> | ||
| <Cond condition={Boolean(LockedBadge({ workspace }))}> |
Contributor
There was a problem hiding this comment.
You probably don't need this since the LockedBadge is already doing the check and returning null if it should not be displayed.
| setLockedWorkspaces([]) | ||
| } | ||
| }, [experimentEnabled, data, filterProps.filter.query]) | ||
|
|
Contributor
There was a problem hiding this comment.
This logic feels very similar to the useWorkspacesToBeLocked, why not use it here as well?
Collaborator
Author
There was a problem hiding this comment.
The useWorkspacesToBeLocked takes a template which the workspaces page doesn't mandate. I could refactor it, but I'd rather merge this as-is and go back and clean up things as we move it out of experimental.
BrunoQuaresma
approved these changes
Aug 2, 2023
Contributor
BrunoQuaresma
left a comment
There was a problem hiding this comment.
Just minor comments but overall, it looks good to go 👍
Member
|
/deploy-pr |
|
🚀 Deploying PR 8655 ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.