Skip to content

fix(cli): unskip test and explicitly set --host in test cmd invocation#8558

Merged
johnstcn merged 3 commits into
mainfrom
cj/stat-mem-test-flake
Jul 17, 2023
Merged

fix(cli): unskip test and explicitly set --host in test cmd invocation#8558
johnstcn merged 3 commits into
mainfrom
cj/stat-mem-test-flake

Conversation

@johnstcn

@johnstcn johnstcn commented Jul 17, 2023

Copy link
Copy Markdown
Member
  • Un-skips the test
  • Explicitly set --host flag when running the cli tests for the stat command as when these are invoked inside a container without a CPU or memory limit set, these tests may fail.

@johnstcn johnstcn self-assigned this Jul 17, 2023

@cdr-bot cdr-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@johnstcn johnstcn merged commit 56889d6 into main Jul 17, 2023
@johnstcn johnstcn deleted the cj/stat-mem-test-flake branch July 17, 2023 16:24
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant