chore: use dependabot groups#8372
Merged
Merged
Conversation
See https://github.blog/changelog/2023-06-30-grouped-version-updates-for-dependabot-public-beta/ for details This will reduce the number of dependabot PRs For go and node dependencies, I leave the exact grouping to engineers who better know which one and how should be grouped.
coadler
requested changes
Jul 7, 2023
Contributor
There was a problem hiding this comment.
I don't really think this is how we should use groups. We want separate commits for each dependency so we can debug them individually, and properly bisect them if they cause a regression.
One thing that I can think of that would benefit from this is our otel deps, which all need to be updated in tandem.
go.nhat.io/otelsql v0.9.0
go.opentelemetry.io/otel v1.14.0
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.14.0
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.14.0
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.14.0
go.opentelemetry.io/otel/sdk v1.14.0
go.opentelemetry.io/otel/trace v1.14.0
Member
|
If we came across a large dependabot upgrade commit we could still continue the log2(n) bisect, albeit with some manual effort. |
Member
Author
|
I removed the super groups for both node and go and added a group for |
coadler
reviewed
Jul 7, 2023
coadler
left a comment
Contributor
There was a problem hiding this comment.
Looks like you removed it for GHA and not node
Also removing the group for dogfood-docker as we only have a docker provider so nothing really to group here.
coadler
approved these changes
Jul 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://github.blog/changelog/2023-06-30-grouped-version-updates-for-dependabot-public-beta/ for details. This will reduce the number of dependent PRs
For go and node dependencies, I leave the exact grouping to engineers who better know how they should be grouped.