feat: add spinner to latencies when refetching#8278
Merged
Conversation
797bebb to
5272ae6
Compare
kylecarbs
approved these changes
Jul 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the proxy is unhealthy or unresponsive, then the loader never shows. So only healthy and reporting proxies get the little spinner. It was just hard to know if the latency was even updated before when you hit that button.
This does not show on first load, it only affects the "refresh latency" button
Peek.2023-06-30.12-13.webm
(I added a random delay for this little video, so the latency number is inaccurate to the time waited)