Skip to content

fix(cli): speed up CLI over SSH#7885

Merged
ammario merged 3 commits into
mainfrom
fix-slow-cli
Jun 7, 2023
Merged

fix(cli): speed up CLI over SSH#7885
ammario merged 3 commits into
mainfrom
fix-slow-cli

Conversation

@ammario
Copy link
Copy Markdown
Member

@ammario ammario commented Jun 7, 2023

By caching the terminal's color profile, we avoid myriad
round trips during command execution.

Resolves #7884

By caching the terminal's color profile, we avoid myriad
round trips during command execution.

Resolves #7884
@ammario ammario requested a review from coadler June 7, 2023 04:54
@ammario ammario enabled auto-merge (squash) June 7, 2023 04:56
Comment thread cli/portforward.go Outdated

"github.com/coder/coder/agent/agentssh"
"github.com/coder/coder/cli/clibase"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bunch of these for some reason

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A careful eye on this one. Impressive.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love my proper import formatting

@ammario ammario merged commit 5eaf809 into main Jun 7, 2023
@ammario ammario deleted the fix-slow-cli branch June 7, 2023 05:23
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

All commands take a long time to complete

2 participants