chore: support signed token query param for web terminal#7197
Merged
Conversation
Emyrk
reviewed
Apr 19, 2023
Member
Emyrk
left a comment
There was a problem hiding this comment.
We should make sure this only works for terminal apps. There is no use outside of it 👍
Emyrk
approved these changes
Apr 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have an issue where we have no way of authenticating the websocket requests to the reconnecting-pty endpoint on the moon because of cross-site cookie constraints.
One solution would be to host the whole terminal page on the moon, but it's included in the whole site bundle AND it makes API requests (other than just the terminal endpoint) so it'd be difficult to move across.
This solution avoids hosting static files on the moon.
The goal is to have the frontend make a request to the new endpoint if it's about to connect to a web terminal on an external workspace proxy, then include it in the URL.