Skip to content

fix: VSCode desktop connection#7120

Merged
matifali merged 23 commits into
coder:mainfrom
matifali:vscode-path
Apr 14, 2023
Merged

fix: VSCode desktop connection#7120
matifali merged 23 commits into
coder:mainfrom
matifali:vscode-path

Conversation

@matifali
Copy link
Copy Markdown
Member

@matifali matifali commented Apr 13, 2023 •
edited
Loading

This PR fixes an issue with VS Code Desktop connection when the URI becomes invalid if the dir in coder_agent resource is not an absolute path or does not start with ~.

Fixes coder/vscode-coder#80

@matifali matifali requested a review from kylecarbs April 13, 2023 14:43
@matifali matifali requested a review from johnstcn April 13, 2023 14:44
johnstcn
johnstcn reviewed Apr 13, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! We should probably add a unit test for this change though.

See here:

coder/agent/agent_test.go

Line 1361 in 17f692a

func TestAgent_Startup(t *testing.T) {

We should probably also document this in docs/template/open-in-coder.md.

@matifali matifali requested a review from johnstcn April 14, 2023 03:55
mafredri
mafredri reviewed Apr 14, 2023
View reviewed changes
Comment thread agent/agent.go
@matifali matifali requested a review from mafredri April 14, 2023 08:17
mafredri
mafredri reviewed Apr 14, 2023
View reviewed changes
Comment thread agent/agent.go Outdated
@matifali matifali requested a review from mafredri April 14, 2023 09:07
mafredri
mafredri approved these changes Apr 14, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

Comment thread docs/templates/open-in-coder.md Outdated
@matifali @mafredri
Update docs/templates/open-in-coder.md
7ef0c98 
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
@matifali matifali merged commit bb43713 into coder:main Apr 14, 2023
@matifali matifali deleted the vscode-path branch April 14, 2023 14:32
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mafredri mafredri mafredri approved these changes

@johnstcn johnstcn johnstcn approved these changes

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@matifali matifali

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: folder URI parameter with relative path fails to open silently

4 participants

@matifali @mafredri @johnstcn @kylecarbs