fix: allow disabling all password auth even if owner#6193
Merged
Conversation
Removes any and all ability to auth with a password.
bpmct
approved these changes
Feb 13, 2023
bpmct
reviewed
Feb 13, 2023
bpmct
left a comment
Member
There was a problem hiding this comment.
Can local accounts still be created?
Member
Author
|
@bpmct good point... I'll check |
Member
Author
|
@bpmct good check. I removed that ability, and now hide the "Create User" button if password auth is disabled. |
deansheather
approved these changes
Feb 13, 2023
kylecarbs
force-pushed
the
disablepassauth
branch
from
February 14, 2023 00:45
067ed9a to
5e22ff2
Compare
kylecarbs
force-pushed
the
disablepassauth
branch
from
February 14, 2023 01:20
5e22ff2 to
b4c2a42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes any and all ability to auth with a password.