chore: Add helper for uniform flags and env vars#588
Merged
Merged
Conversation
da08c31 to
b949d1a
Compare
Codecov Report
@@ Coverage Diff @@
## main #588 +/- ##
==========================================
- Coverage 63.68% 63.43% -0.26%
==========================================
Files 195 196 +1
Lines 11313 11323 +10
Branches 85 85
==========================================
- Hits 7205 7183 -22
- Misses 3351 3378 +27
- Partials 757 762 +5
Continue to review full report at Codecov.
|
b78809a to
d5bf66c
Compare
|
@kylecarbs can this be closed or does it still need to be done? |
Member
|
This isn't mandatory for alpha but should be something we tackle sooner rather than later. |
kylecarbs
reviewed
Mar 28, 2022
kylecarbs
approved these changes
Mar 28, 2022
Member
kylecarbs
left a comment
There was a problem hiding this comment.
Minor nits, but overall great addition!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small package dedicated to cleaning and standardizing flags on the cli. By doing so we gain: