Conversation
This allows zero-trust authentication for all AWS instances. Prior to this, AWS instances could be used by passing `CODER_TOKEN` as an environment variable to the startup script. AWS explicitly states that secrets should not be passed in startup scripts because it's user-readable.
Member
Author
|
@bpmct once this lands, we can remove |
Codecov Report
@@ Coverage Diff @@
## main #570 +/- ##
==========================================
+ Coverage 63.43% 63.73% +0.30%
==========================================
Files 195 196 +1
Lines 11321 11514 +193
Branches 85 85
==========================================
+ Hits 7181 7338 +157
- Misses 3380 3399 +19
- Partials 760 777 +17
Continue to review full report at Codecov.
|
coadler
approved these changes
Mar 28, 2022
Comment on lines
+18
to
+30
| const ( | ||
| Other Region = "other" | ||
| HongKong Region = "hongkong" | ||
| Bahrain Region = "bahrain" | ||
| CapeTown Region = "capetown" | ||
| Milan Region = "milan" | ||
| China Region = "china" | ||
| GovCloud Region = "govcloud" | ||
| ) | ||
|
|
||
| var ( | ||
| All = []Region{Other, HongKong, Bahrain, CapeTown, Milan, China, GovCloud} | ||
| ) |
Contributor
There was a problem hiding this comment.
These variable names should probably be prefixed with Region.
Member
Author
There was a problem hiding this comment.
It felt unnecessarily verbose due to the small scope of the package.
Emyrk
approved these changes
Mar 28, 2022
Member
Emyrk
left a comment
There was a problem hiding this comment.
I posted some nits. Nothing that will block a merge.
I am missing context on what this is actually used for though. It's only used for testing? We test in AWS and GCP?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows zero-trust authentication for all AWS instances.
Prior to this, AWS instances could be used by passing
CODER_TOKENas an environment variable to the startup script. AWS explicitly
states that secrets should not be passed in startup scripts because
it's user-readable.