fix: fix security vulnerabilities reported by CodeQL#5467
Merged
Conversation
mafredri
approved these changes
Dec 19, 2022
Member
mafredri
left a comment
There was a problem hiding this comment.
Had two questions but otherwise looks good! 👍
| codersdk.GitProviderBitBucket: regexp.MustCompile(`bitbucket\.org`), | ||
| codersdk.GitProviderGitLab: regexp.MustCompile(`gitlab\.com`), | ||
| codersdk.GitProviderGitHub: regexp.MustCompile(`github\.com`), | ||
| codersdk.GitProviderAzureDevops: regexp.MustCompile(`^(https?:\/\/)?dev\.azure\.com(\/.*)?$`), |
Member
There was a problem hiding this comment.
Does forward slash need to be escaped here? It’s often a separator in regexes, requiring the escape, but unsure if needed here.
Member
Author
There was a problem hiding this comment.
I think you're right, I'll remove the slashes
deansheather
commented
Dec 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the vulnerabilities reported by CodeQL in #5279.