Skip to content

feat: add flag for token lifetime#5385

Merged
f0ssel merged 5 commits into
mainfrom
f0ssel/tokens-exp
Dec 12, 2022
Merged

feat: add flag for token lifetime#5385
f0ssel merged 5 commits into
mainfrom
f0ssel/tokens-exp

Conversation

@f0ssel
Copy link
Copy Markdown
Member

@f0ssel f0ssel commented Dec 12, 2022

Closes #4910

What this does:

@f0ssel f0ssel requested a review from a team as a code owner December 12, 2022 17:28
@f0ssel f0ssel requested review from BrunoQuaresma and removed request for a team December 12, 2022 17:28
@bpmct
Copy link
Copy Markdown
Member

bpmct commented Dec 12, 2022

Edited the description to add

  • Defaults new tokens to 30 days

quick turnaround on iteration :)

Copy link
Copy Markdown
Contributor

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@f0ssel
Copy link
Copy Markdown
Member Author

f0ssel commented Dec 12, 2022

Edited the description to add

  • Defaults new tokens to 30 days

quick turnaround on iteration :)

This happens automatically in the CLI with the default value set.

@f0ssel f0ssel requested a review from deansheather December 12, 2022 20:25
@f0ssel f0ssel merged commit 40a5c04 into main Dec 12, 2022
@f0ssel f0ssel deleted the f0ssel/tokens-exp branch December 12, 2022 20:39
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: site-wide admin setting to configure expiration of any generated API key Configurable duration for API tokens

4 participants