Skip to content

fix: Close tty first in ptytest cleanup #5252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mafredri merged 4 commits into from
Dec 2, 2022
Merged

fix: Close tty first in ptytest cleanup #5252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
35787ec
fix: Close ptytest ttys asynchronously to enable timeout
mafredri Dec 2, 2022
af76f94
Log what we are closing in ptytest
mafredri Dec 2, 2022
ba7d55a
Simplify
mafredri Dec 2, 2022
5147c22
Avoid failing test
mafredri Dec 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@
"slogtest",
"sourcemapped",
"Srcs",
"stdbuf",
"stretchr",
"STTY",
"stuntest",
Expand Down
9 changes: 7 additions & 2 deletions pty/ptytest/ptytest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,13 @@ func create(t *testing.T, ptty pty.PTY, name string) *PTY {
ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitShort)
defer cancel()

_ = out.Close()
_ = ptty.Close()
Comment thread
mafredri marked this conversation as resolved.
// Close pty only so that the copy goroutine can consume the
// remainder of it's buffer and then exit.
err := ptty.Close()
// Pty may already be closed, so don't fail the test, but log
// the error in case it's significant.
logf(t, name, "closed pty: %v", err)

select {
case <-ctx.Done():
fatalf(t, name, "cleanup", "copy did not close in time")
Expand Down