chore: enable debug logging for gotestsum#5248
Merged
Merged
Conversation
deansheather
approved these changes
Dec 2, 2022
deansheather
left a comment
Member
There was a problem hiding this comment.
LGTM as long as it's temporary so we can report a bug upstream
Member
Author
|
I didn't analyze the PTY logic, rather wanted to see the output. Looking at the test output, we can see that all the last assertions have been matched. It doesn't look to me that something is chopped, but I might be wrong. Do you think that it is still valid to merge this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #5247
This PR enables debug logging for
gotestsum. It seems that there is an interleave between some logger calls, sogotestsumcan't find the line with the prefix--- PASS:. With the debug mode enabled we should the output fromgo test.