Get previous template version#5230
Merged
Merged
Conversation
mafredri
reviewed
Dec 2, 2022
Member
mafredri
left a comment
There was a problem hiding this comment.
Didn't fully understand the logic in the fake db but maybe I've misunderstood what we're trying to do there, also had some questions about the query. In general code looks good.
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
mafredri
reviewed
Dec 5, 2022
Member
mafredri
left a comment
There was a problem hiding this comment.
Ok, after your explanations Bruno and looking at this again, query and database fake implementation looks fine (except fake was missing one thing, see suggestion).
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
mafredri
approved these changes
Dec 5, 2022
Member
mafredri
left a comment
There was a problem hiding this comment.
It'd be nice if you could do the remaining errors => xerrors and error block changes, but otherwise looks great. 👍🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to get the previous template version in the UI, mostly to get the files related to it and show the diff between them on the template version page. so I'm going to add an endpoint for that. In the meantime, I would appreciate your thoughts about the incoming changes like the SQL query and database fake logic.