Skip to content

feat: add windows amd64 installer#4719

Merged
deansheather merged 7 commits into
mainfrom
dean/installer
Oct 25, 2022
Merged

feat: add windows amd64 installer#4719
deansheather merged 7 commits into
mainfrom
dean/installer

Conversation

@deansheather
Copy link
Copy Markdown
Member

@deansheather deansheather commented Oct 24, 2022

Adds a Windows amd64 installer (built on Linux) using makensis. NSIS is an alternative to MSI which can easily be built on platforms other than Windows, and is used by well-known apps such as VLC and VirtualBox.

Drops the following files in C:\Program Files\Coder:

  • bin/coder.exe
  • uninstaller.exe
  • license.txt

Optionally adds bin to PATH. Registers Coder as an app in Windows settings so users can easily uninstall it.

coder_0.10.2-devel+bf3224e3_windows_amd64_installer_NnWUVJKzWY.mp4

@kylecarbs
Copy link
Copy Markdown
Member

Does the user need to sign out and sign in for the PATH to change?

@deansheather
Copy link
Copy Markdown
Member Author

Does the user need to sign out and sign in for the PATH to change?

@kylecarbs It's the easiest way to get PATH updates to apply without having to run crazy commands to force refresh the PATH variable AFAIK

Copy link
Copy Markdown
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!

Could you adjust this in the README? https://github.com/coder/coder#getting-started

Add under:

The easiest way to install Coder is to use our [install script](https://github.com/coder/coder/blob/main/install.sh) for Linux and macOS. For Windows, use our [installer](<link to latest release installer bin here>).

Comment thread scripts/installer/path.nsh
@deansheather
Copy link
Copy Markdown
Member Author

@kylecarbs there's no permalink for the installer, so I put the following in the README instead:

For Windows, use the latest `..._installer.exe` file from GitHub Releases.

@kylecarbs
Copy link
Copy Markdown
Member

@deansheather hmm, that makes sense to me. link to the latest release too!

Thoughts on this? https://stackoverflow.com/questions/6979741/setting-environment-variables-requires-reboot-on-64-bit

btw this isn't blocking, just cool if it's easy to do

@kylecarbs
Copy link
Copy Markdown
Member

@deansheather can we include the version somewhere in the installer UI? Might be helpful for folks

@matifali
Copy link
Copy Markdown
Member

matifali commented Oct 25, 2022

Also, it will allow publishing on winget as currently, it does not allow publishing a portable app from inside a zip.
#3729

@deansheather
Copy link
Copy Markdown
Member Author

deansheather commented Oct 25, 2022

yep @matifali this is a follow up I'd like to do after merge :D

@deansheather deansheather merged commit 067362c into main Oct 25, 2022
@deansheather deansheather deleted the dean/installer branch October 25, 2022 14:19
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants