fix: Add names to config properties for the UI#4718
Merged
Conversation
This was reverted in the configuration PR, which broke the UI.
f0ssel
approved these changes
Oct 24, 2022
Member
f0ssel
left a comment
There was a problem hiding this comment.
Yeah I had a todo somewhere to add those back, but I didn't know if we just wanted to generate titles based on the keys or something. This looks great, sorry I didn't realize it was being used in the UI.
| <OptionsTable | ||
| options={{ | ||
| oidc_client_id: deploymentConfig.oidc_client_id, | ||
| oidc_client_secret: deploymentConfig.oidc_client_secret, |
Member
There was a problem hiding this comment.
We can add this back once I get better sensitive data support. I already have a branch I'm working on for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was reverted in the configuration PR, which broke the UI.