Skip to content

feat: Add emoji picker to group settings#4685

Merged
kylecarbs merged 1 commit into
mainfrom
groupmoji
Oct 21, 2022
Merged

feat: Add emoji picker to group settings#4685
kylecarbs merged 1 commit into
mainfrom
groupmoji

Conversation

@kylecarbs

Copy link
Copy Markdown
Member

Fixes #4413.

@kylecarbs kylecarbs requested a review from bpmct October 21, 2022 17:13
@kylecarbs kylecarbs requested a review from a team as a code owner October 21, 2022 17:13
@kylecarbs kylecarbs self-assigned this Oct 21, 2022
@kylecarbs kylecarbs requested review from Kira-Pilot and removed request for a team October 21, 2022 17:13
Comment thread site/src/pages/GroupsPage/SettingsGroupPageView.tsx Outdated
"--rgb-background": theme.palette.background.paper,
"--rgb-input": colors.gray[17],
"--rgb-color": colors.gray[4],
},

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add this site/src/theme/overrides.ts? I feel like I might not look for it here.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just copied this from the template settings one, but I assume we'll abstract this (maybe once it's used once more?).

@Kira-Pilot Kira-Pilot Oct 21, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could be wrong, but I thought the @global key meant any classes defined within would be defined globally. So, if this is already declared in template settings, I'm surprised we need it here, too.

I'm suggesting we move it to overrides because we have a bunch of other globals there, and it's nice to have them colocated. But not a blocker.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the @global will go away when the component is unmounted, so it won't actually apply globally to all pages, just to the global scope on this page.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh, interesting; thanks for explaining. Alrighty, let's keep it!

@Kira-Pilot Kira-Pilot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@kylecarbs kylecarbs enabled auto-merge (squash) October 21, 2022 19:36
@kylecarbs kylecarbs merged commit 0d27b59 into main Oct 21, 2022
@kylecarbs kylecarbs deleted the groupmoji branch October 21, 2022 19:42
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

groups: add icon/emoji to groups

3 participants