Conversation
| "--rgb-background": theme.palette.background.paper, | ||
| "--rgb-input": colors.gray[17], | ||
| "--rgb-color": colors.gray[4], | ||
| }, |
There was a problem hiding this comment.
Do we want to add this site/src/theme/overrides.ts? I feel like I might not look for it here.
There was a problem hiding this comment.
I just copied this from the template settings one, but I assume we'll abstract this (maybe once it's used once more?).
There was a problem hiding this comment.
I could be wrong, but I thought the @global key meant any classes defined within would be defined globally. So, if this is already declared in template settings, I'm surprised we need it here, too.
I'm suggesting we move it to overrides because we have a bunch of other globals there, and it's nice to have them colocated. But not a blocker.
There was a problem hiding this comment.
I believe the @global will go away when the component is unmounted, so it won't actually apply globally to all pages, just to the global scope on this page.
There was a problem hiding this comment.
Ohhh, interesting; thanks for explaining. Alrighty, let's keep it!
Fixes #4413.