Skip to content

fix: apply loadBalancerIP and externalTrafficPolicy values in helm chart#4427

Merged
deansheather merged 2 commits into
coder:mainfrom
andrei-nefeli:loadBalancerIP
Oct 8, 2022
Merged

fix: apply loadBalancerIP and externalTrafficPolicy values in helm chart#4427
deansheather merged 2 commits into
coder:mainfrom
andrei-nefeli:loadBalancerIP

Conversation

@andrei-nefeli

Copy link
Copy Markdown
Contributor

we have loadBalancerIP and externalTrafficPolicy in values, and service must have them too

we have loadBalancerIP and externalTrafficPolicy in values, and service must have them too
@ammario ammario requested a review from deansheather October 8, 2022 19:34

@deansheather deansheather left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! 😄

Comment thread helm/templates/service.yaml Outdated
Comment thread helm/templates/service.yaml Outdated
@deansheather deansheather changed the title loadBalancerIP and externalTrafficPolicy adding fix: apply loadBalancerIP and externalTrafficPolicy values in helm chart Oct 8, 2022
@deansheather deansheather enabled auto-merge (squash) October 8, 2022 21:08
@deansheather deansheather merged commit dd5173b into coder:main Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants