Skip to content

chore: add ignoreRestSiblings to no-unused-vars ESLint rule#4404

Merged
jsjoeio merged 2 commits into
mainfrom
jsjoeio/fix-markdown
Oct 7, 2022
Merged

chore: add ignoreRestSiblings to no-unused-vars ESLint rule#4404
jsjoeio merged 2 commits into
mainfrom
jsjoeio/fix-markdown

Conversation

@jsjoeio

@jsjoeio jsjoeio commented Oct 6, 2022

Copy link
Copy Markdown
Contributor

This PR adds a new setting to one of our ESLint rules called ignoreRestSiblings which will come in handy if we use the spread operator to pass an object and exclude specific properties.

  • chore: add ignoreRestSiblings to eslint config
  • fix(site): remove eslint warning in

@jsjoeio jsjoeio self-assigned this Oct 6, 2022
@jsjoeio jsjoeio changed the title jsjoeio/fix markdown chore: add ignoreRestSiblings to no-unused-vars ESLint rule Oct 6, 2022
@jsjoeio jsjoeio requested a review from BrunoQuaresma October 6, 2022 21:05
@jsjoeio jsjoeio marked this pull request as ready for review October 6, 2022 21:05
@jsjoeio jsjoeio requested a review from a team as a code owner October 6, 2022 21:05

@BrunoQuaresma BrunoQuaresma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for adding this.

@jsjoeio jsjoeio merged commit 2b6586d into main Oct 7, 2022
@jsjoeio jsjoeio deleted the jsjoeio/fix-markdown branch October 7, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants