Conversation
deansheather
approved these changes
Oct 6, 2022
deansheather
left a comment
Member
There was a problem hiding this comment.
if you're triple sure this doesn't give every unlicensed deployment audit logging for free then LGTM 👍
f0ssel
approved these changes
Oct 6, 2022
f0ssel
left a comment
Member
There was a problem hiding this comment.
Makes sense, it wasn't clear to me in the code that audit logging was on by default.
Member
Author
|
@f0ssel we should probably have better testing around these warnings anyways, since it's a big no-no to display any if unlicensed (and maybe we should just change the code to do that). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4383.