Skip to content

feat: tokens#4380

Merged
f0ssel merged 17 commits into
mainfrom
f0ssel/machine-keys
Oct 6, 2022
Merged

feat: tokens#4380
f0ssel merged 17 commits into
mainfrom
f0ssel/machine-keys

Conversation

@f0ssel

@f0ssel f0ssel commented Oct 5, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Closes #3692

@f0ssel f0ssel marked this pull request as ready for review October 5, 2022 20:59
@f0ssel f0ssel requested a review from a team as a code owner October 5, 2022 20:59
@f0ssel f0ssel requested review from Emyrk and Kira-Pilot and removed request for a team October 5, 2022 20:59
@f0ssel f0ssel marked this pull request as draft October 6, 2022 14:38
@f0ssel f0ssel marked this pull request as ready for review October 6, 2022 17:01
@f0ssel f0ssel requested review from a team and bpmct and removed request for Emyrk October 6, 2022 17:01
kylecarbs
kylecarbs reviewed Oct 6, 2022
View reviewed changes
Comment thread cli/keys.go Outdated
Comment thread cli/keys.go Outdated
Comment thread coderd/coderd.go
bpmct
bpmct reviewed Oct 6, 2022
View reviewed changes

@bpmct bpmct left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are "machine key" and "personal access token" interchangeable?

I prefer PAT / "token", but don't have strong feelings either way, especially if the behaviors are the same. The main rationale is I haven't seen "machine key" used commonly in software like this, but 🤷🏼

@coadler

coadler commented Oct 6, 2022

Copy link
Copy Markdown
Contributor

I find "machine key" a bit confusing as we have machine keys in Tailscale as well.

@f0ssel

f0ssel commented Oct 6, 2022

Copy link
Copy Markdown
Member Author

machine key is programmer codename 100% - it's because the data model is an api key with the login type "machine". I can change this to whatever makes the most sense for product.

In v1 we used coder tokens and also call the api key flag in the CLI for v2 --token. Can we call it just coder tokens again? PAT doesn't really mean anything to me personally.

@f0ssel f0ssel requested a review from bpmct October 6, 2022 18:32
@f0ssel f0ssel changed the title feat: machine keys feat: tokens Oct 6, 2022
@bpmct

bpmct commented Oct 6, 2022

Copy link
Copy Markdown
Member

Tokens makes sense to me!

@f0ssel f0ssel requested a review from kylecarbs October 6, 2022 18:41
deansheather
deansheather approved these changes Oct 6, 2022
View reviewed changes

@deansheather deansheather left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine but you still say "machine token" in a lot of places. Also, using both "api key" and "token" and "key" and "session token" for the same thing is confusing and we should just stick to one where possible IMO

Comment thread coderd/apikey.go Outdated
Comment thread coderd/users_test.go Outdated
Comment thread coderd/users_test.go Outdated
@f0ssel f0ssel enabled auto-merge (squash) October 6, 2022 18:57
@f0ssel f0ssel merged commit f5df548 into main Oct 6, 2022
@f0ssel f0ssel deleted the f0ssel/machine-keys branch October 6, 2022 19:02
@f0ssel f0ssel mentioned this pull request Oct 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deansheather deansheather deansheather approved these changes

@Kira-Pilot Kira-Pilot Awaiting requested review from Kira-Pilot Kira-Pilot was automatically assigned from coder/ts

@bpmct bpmct Awaiting requested review from bpmct

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create long-lived tokens for CI/CD/automation (or tokens for a specific duration)

5 participants

@f0ssel @coadler @bpmct @kylecarbs @deansheather