Skip to content

feat: add warning if workspace page becomes stale#4375

Merged
Kira-Pilot merged 6 commits into
mainfrom
add-stale-warning/kira-pilot
Oct 5, 2022
Merged

feat: add warning if workspace page becomes stale#4375
Kira-Pilot merged 6 commits into
mainfrom
add-stale-warning/kira-pilot

Conversation

@Kira-Pilot

@Kira-Pilot Kira-Pilot commented Oct 5, 2022

Copy link
Copy Markdown
Member

Added a warning for stale workspaces. Also updated design for warnings based on @BrunoQuaresma's mocks for errors.

All three warnings on workspace page shown below:
Screen Shot 2022-10-05 at 3 59 44 PM

@Kira-Pilot Kira-Pilot requested a review from a team as a code owner October 5, 2022 15:10
@Kira-Pilot Kira-Pilot requested review from BrunoQuaresma and removed request for a team October 5, 2022 15:10
@Kira-Pilot Kira-Pilot changed the title Add stale warning/kira pilot feat: add warning if workspace page becomes stale Oct 5, 2022
Comment thread site/src/components/WarningAlert/WarningAlert.tsx Outdated

@BrunoQuaresma BrunoQuaresma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good changes!

@Kira-Pilot Kira-Pilot merged commit 3ad5e11 into main Oct 5, 2022
@Kira-Pilot Kira-Pilot deleted the add-stale-warning/kira-pilot branch October 5, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants