Skip to content

fix: Check for a response body when dialing the Tailnet WebSocket#4327

Merged
kylecarbs merged 2 commits into
mainfrom
fetchfix
Oct 5, 2022
Merged

fix: Check for a response body when dialing the Tailnet WebSocket#4327
kylecarbs merged 2 commits into
mainfrom
fetchfix

Conversation

@kylecarbs

@kylecarbs kylecarbs commented Oct 3, 2022

Copy link
Copy Markdown
Member

There was a panic in this code that caused it to fail on error!

@kylecarbs
fix: Check for a response body when dialing the Tailnet WebSocket
e094827 
There was a panic in this code that caused it to fail on error!
@kylecarbs kylecarbs requested a review from mafredri October 3, 2022 15:04
@kylecarbs kylecarbs self-assigned this Oct 3, 2022
@kylecarbs kylecarbs mentioned this pull request Oct 3, 2022
Merged
mafredri
mafredri approved these changes Oct 3, 2022
View reviewed changes

@mafredri mafredri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kylecarbs kylecarbs merged commit 504cd46 into main Oct 5, 2022
@kylecarbs kylecarbs deleted the fetchfix branch October 5, 2022 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mafredri mafredri mafredri approved these changes

Assignees

@kylecarbs kylecarbs

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kylecarbs @mafredri