Skip to content

Revert "refactor(ci): conditionally run jobs based on file changes (#4242)"#4321

Merged
kylecarbs merged 1 commit into
mainfrom
mafredri/revert-conditional-ci
Oct 3, 2022
Merged

Revert "refactor(ci): conditionally run jobs based on file changes (#4242)"#4321
kylecarbs merged 1 commit into
mainfrom
mafredri/revert-conditional-ci

Conversation

@mafredri
Copy link
Copy Markdown
Member

@mafredri mafredri commented Oct 3, 2022

This reverts commit f9b7588.

Tests and golangci-lint were being skipped for some reason, reverting to see if that fixes it.

@mafredri mafredri self-assigned this Oct 3, 2022
@mafredri mafredri requested review from a team and jsjoeio October 3, 2022 14:01
@kylecarbs kylecarbs merged commit 74cd31b into main Oct 3, 2022
@kylecarbs kylecarbs deleted the mafredri/revert-conditional-ci branch October 3, 2022 14:51
@jsjoeio
Copy link
Copy Markdown
Contributor

jsjoeio commented Oct 4, 2022

Any reason we didn't simply revert bebfe7e instead of the entire PR? Were there other changes you expected to run that weren't running?

@mafredri
Copy link
Copy Markdown
Member Author

mafredri commented Oct 4, 2022

@jsjoeio that commit is part of the PR, but the PR is squash merged onto main (ends up being a single commit), so unfortunately reverting a single commit from the PR is impossible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants