chore: refactor dialogs#3935
Merged
Merged
Conversation
Pausing on the typing part for now, leaving this as a refactor
presleyp
requested review from
BrunoQuaresma and
Kira-Pilot
and removed request for
a team
September 7, 2022 17:51
|
|
||
| export interface DeleteDialogProps { | ||
| isOpen: boolean | ||
| handleConfirm: () => void |
Contributor
There was a problem hiding this comment.
Why not keep using the onSomeAction pattern? I think this is the most used one from libs.
Contributor
Author
There was a problem hiding this comment.
The DeleteWorkspaceDialog component used handle, but I'd like it to be consistent so I'll switch it
BrunoQuaresma
approved these changes
Sep 7, 2022
BrunoQuaresma
left a comment
Contributor
There was a problem hiding this comment.
I'm ok with the changes. Just two minor stuff:
- A question about the "pattern" that we want to use for event handlers
- Idk but the diffs on Storybook don't look correct - not showing buttons. Idk if it is something fixable so I will let the approval to you
Contributor
Author
|
@BrunoQuaresma yeah I've seen this storybook issue enough times now that I'm not concerned that it's a problem in the actual app, but I'll have to try to figure out what the problem is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a refactor to lay the groundwork for #3384.
I've checked that this leaves the delete terminal dialog in a good state but I'm blocked on checking the delete workspace dialog right now.