Skip to content

revert: Makefile buff-ification (#3700)#3848

Merged
kylecarbs merged 1 commit into
mainfrom
revertmake
Sep 2, 2022
Merged

revert: Makefile buff-ification (#3700)#3848
kylecarbs merged 1 commit into
mainfrom
revertmake

Conversation

@kylecarbs
Copy link
Copy Markdown
Member

This caused the following issues:

  • Slim binaries weren't being updated.
  • The coder.tar.ztd was misplaced.
  • There is no coder.sha1 file with proper filenames.

This should be reintroduced in a future change with those fixes.

This caused the following issues:
- Slim binaries weren't being updated.
- The coder.tar.ztd was misplaced.
- There is no coder.sha1 file with proper filenames.

This should be reintroduced in a future change with those fixes.
@kylecarbs kylecarbs requested a review from sreya September 2, 2022 19:38
@kylecarbs kylecarbs self-assigned this Sep 2, 2022
@kylecarbs kylecarbs merged commit e490bdd into main Sep 2, 2022
@kylecarbs kylecarbs deleted the revertmake branch September 2, 2022 19:46
deansheather added a commit that referenced this pull request Sep 3, 2022
deansheather added a commit that referenced this pull request Sep 6, 2022
* Revert "revert: Makefile buff-ification (#3700) (#3848)"

This reverts commit e490bdd.

* fix: fix slim targets in makefile

* fix: don't clobber slim binaries, make sure they're in the correct location
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants