Build enterprise coder binary by default#3517
Merged
Merged
Conversation
Signed-off-by: Spike Curtis <spike@coder.com>
johnstcn
approved these changes
Aug 15, 2022
Signed-off-by: Spike Curtis <spike@coder.com>
Signed-off-by: Spike Curtis <spike@coder.com>
Signed-off-by: Spike Curtis <spike@coder.com>
johnstcn
approved these changes
Aug 16, 2022
kylecarbs
requested changes
Aug 16, 2022
Member
kylecarbs
left a comment
There was a problem hiding this comment.
I believe this would make Unknown appear in GitHub for the license field.
Can we make LICENSE.agpl named LICENSE instead? And still have the Enterprise license?
| func main() { | ||
| rand.Seed(time.Now().UnixMicro()) | ||
|
|
||
| cmd, err := cli.Root().ExecuteC() |
Member
There was a problem hiding this comment.
Do we plan on having a separate CLI package to maintain? How do we imagine this working?
Contributor
Author
There was a problem hiding this comment.
There will eventually be a separate enterprise cli package, because CLI commands for enterprise features will be in it. It will import all the core commands from the AGPL cli package.
Signed-off-by: Spike Curtis <spike@coder.com>
kylecarbs
approved these changes
Aug 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3277
We now build enterprise binary by default. If anyone wants just the AGPL code, they can use our build scripts with
--agplflag.(Note that this PR doesn't introduce any enterprise code; the main.go is just a direct copy of the AGPL version)