Repository navigation
Conversation
Contributor
|
👋 Hey @sreya! This PR is targeting the Only bug fixes should be cherry-picked to release branches. If this is a bug fix, please update the PR title to match the conventional commit format: If this is not a bug fix, it likely should not target a release branch. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #31654 to
release/2.30.Original PR: #31654 (chore: use environments for various CI pipelines)
Merge commit: b0cc77d
Release tags run the
release.yamlfrom their own branch, and pushes to this branch run its ownci.yaml. Without this backport, releases and builds fromrelease/2.30keep reading the repo-level signing secrets and break once those are deleted.Changes: the cherry-pick conflicted because this branch predates the
setup-miseandpnpm-installactions, so I reapplied the same intent by hand:release.yamlrelease:environment: release.publish-homebrewandpublish-winget:environment: release-publish.ci.yamlbuild:environment: ci-signing.setup-gogetsuse-cache: false, andsetup-nodegets a newuse-cacheinput (default"true") that these jobs set to"false".publish.shon real releases.release.yamlbuild-dylib:environment: release(it signs with the Apple secrets) andsetup-gocaching off. Note:build-dylibandreleaseboth userelease, so a release from this branch asks for approval twice.ci.yamlbuild-dylib:environment: ${{ (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/release/')) && 'ci-signing' || '' }}, because this job also runs unsigned on PRs, where theci-signingbranch policy would reject it. Plussetup-gocaching off. This PR's own CI exercises the no-environment path.pnpm-installchange (that action doesn't exist here) and the Dependabot changes (Dependabot only reads its config from the default branch).@sreya for review.
Generated with Coder Agents.