Repository navigation
feat(site): add ghost easter egg to the navbar logo - #31719
Open
tracyjohnsonux wants to merge 2 commits into
Open
tracyjohnsonux wants to merge 2 commits into
tracyjohnsonux wants to merge 2 commits into
Conversation
From Oct 24 to 31, the navbar Coder logo periodically glitches into a backlit silhouette, blinks, and glitches back; hovering holds it dark. ?halloween=1 and ?halloween=0 force it on or off. It is off for reduced motion, custom logos, and pixel snapshots.
Drop the Halloween date window, the ?halloween override, and the automatic cycle. The navbar logo now glitches into the ghost only while hovered. The effect logic is reduced to one settle loop, and the blink is a looping Web Animation instead of a timer chain.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hovering the navbar Coder logo turns it into a "Ghost in the shell". It glitches into a backlit black silhouette with TV-style horizontal tearing and scanlines, and two eyes open and blink every few seconds. When the pointer leaves, it glitches back.
There's nothing to configure: it's a hover easter egg, off for
prefers-reduced-motionand for custom logos (Appearance > Logo URL always wins). Whether and when to ship it, and the timings inGHOST_LOGO_TIMING, are left to reviewers. It's driven imperatively on the SVG nodes (ghostLogoController.ts), so glitch frames don't re-render React.To try it: hover the logo in Storybook
components/Icons/GhostLogoor on any dashboard page.For reviewers:
fill-surface-primary, so it reads as a white ghost with a dark halo, the inverse of the dark-theme look.Verification and decision log
Checks (all passed):
pnpm check,pnpm lint, unit tests (includingghostLogoController.test.ts), thepre-commithook, and thepre-pushhook (make pre-push, including tests).Browser checks (headless Chromium, Playwright, Storybook):
History:
?halloweenoverride, and it played on its own every 9s.Fixes carried over:
sleep()used to leave anabortlistener on the shared signal until the logo unmounted.frontend-deep-review: findings fixed in the earlier round. One was rejected: making the
ProductLogoprop required, becauseProductLogohas eight other call sites that don't pass it. doc-check (author self-check): no blocking findings.docs/admin/setup/appearance.md("The default is the Coder logo.") is still accurate.Generated by Coder Agents on behalf of @tracyjohnsonux.