Repository navigation
Conversation
kylecarbs
approved these changes
Nov 3, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Terraform 1.14 added actions. Their hook messages (
action_start,action_progress,action_complete,action_errored) sendhook.actionas an object, butterraformProvisionLogHook.Actionis astring.json.Unmarshaltherefore fails on these lines, andparseTerraformLogLinefalls back to logging the raw JSON line. As a result, every action line shows up in workspace build logs as a JSON blob, cut off at 1024 characters, instead of its@message.This change decodes
hook.actionfrom either a string or an object, using the action'saddrfor objects, so action lines log their@messagelike other hook lines. Lines whosehook.actionis neither shape still fall back to the raw line.Found while building coder/terraform-provider-kubestream, a provider whose action streams pod startup progress into build logs.
Build log from a local Coder build of a template with an action, before and after
Before:
After:
Action lines still produce the existing sampled "failed to extract timings" warning, because
action_*isn't a timing kind. That is unchanged by this PR.Note
This PR was written with an AI coding agent (Xum). I verified it with the new unit test (which fails without the fix) and with an end-to-end build on a local Coder deployment, shown above.