Skip to content

fix: only inject session tokens into trusted app links (#31208) - #31214

Merged
EhabY merged 2 commits into
release/2.29from
fix/site-app-token-destination-2.29
Oct 23, 2026
Merged

EhabY merged 2 commits into
release/2.29from
fix/site-app-token-destination-2.29

Conversation

@EhabY

@EhabY EhabY commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Backport of #31208 to release/2.29.

This branch fetches the key when the link renders instead of on click, so the same checks gate that query. Sub-agent apps skip it. Tests live in AppLink.jest.tsx (Jest) here.

Generated with Coder Agents.

External app links that use `$SESSION_TOKEN` now receive a session
token only when they open a known Coder IDE handler and point to this
deployment. Other links mint no key and render disabled with a tooltip.
Sub-agent apps never get a token.
@EhabY EhabY added the backport/v2.29 Backport PR targeting release/2.29 label Oct 23, 2026
@EhabY EhabY self-assigned this Oct 23, 2026
@EhabY
EhabY merged commit 5490dbd into release/2.29 Oct 23, 2026
22 of 23 checks passed
@EhabY
EhabY deleted the fix/site-app-token-destination-2.29 branch October 23, 2026 18:48
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/v2.29 Backport PR targeting release/2.29

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants