Repository navigation
Conversation
The generated notes told users to `docker pull ghcr.io/coder/coder:2.37.5`, but the release workflow tags images through scripts/image_tag.sh, which always emits `v<version>`; the un-prefixed tag does not exist on ghcr.io (404). Every release cut with the wizard carries the broken command. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The release wizard writes this into every release's notes:
but the workflow tags images with
scripts/image_tag.sh, which always emitsv<version>.ghcr.io/coder/coder:2.37.5returns 404;ghcr.io/coder/coder:v2.37.5is the real tag. Checked against v2.37.5, v2.37.4, v2.38.0 and v2.29.19 on ghcr.io: only thev-prefixed manifests exist.release.gostrips thevbefore formatting the tag (strings.TrimPrefix(newVersion.String(), "v")). The old bash generator usedimage_tag.shdirectly and got it right.Change
Format the tag with
newVersion.String()(keeps thev), with a comment pointing atimage_tag.shas the source of truth.Affected published notes (36 releases back to v2.29.19) can be fixed with
gh release edit --notes-file; this PR only fixes future ones.🤖 Generated with Claude Code
Part of ENT-224