Repository navigation
refactor(coderd): drop pass-through chat message conversion wrappers - #31023
Open
ibetitsmike wants to merge 1 commit into
Open
ibetitsmike wants to merge 1 commit into
ibetitsmike wants to merge 1 commit into
Conversation
convertChatMessage, convertChatMessages, convertChatQueuedMessage, convertChatQueuedMessagePtr, convertChatQueuedMessages, and lookupEnabledChatModelConfigByID only forwarded to db2sdk and the store. Call those directly.
Collaborator
Author
|
@codex review
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
ibetitsmike
marked this pull request as ready for review
October 19, 2026 22:48
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes six helpers in
coderd/exp_chats.gothat only forwarded todb2sdkor the store:convertChatMessage,convertChatMessages,convertChatQueuedMessage,convertChatQueuedMessagePtr,convertChatQueuedMessages, andlookupEnabledChatModelConfigByID. Their callers now calldb2sdk.ChatMessage,db2sdk.ChatQueuedMessages, andGetEnabledChatModelConfigByIDdirectly, and convert message lists withslice.List. It adds 8 lines and removes 46.Why it is safe: each call site now runs the function the wrapper called.
slice.Listanddb2sdk.ChatQueuedMessagesreturn an empty, non-nil slice for no rows, as the wrappers did, so empty lists still encode as[]. A repository-wide search finds no other references to the deleted names.Review focus: the two pointer results use
new(db2sdk.ChatMessage(...))andnew(db2sdk.ChatQueuedMessage(...)), the Go 1.26 form ofnewthat takes an expression.coderd/provisionerdaemons.goalready uses it.#29662 edits the same
ChatMessagesResponseliteral ingetChatMessages, so the two conflict in that one hunk.Validation: on
mainand on this branch,go test ./coderd -run '^(TestPostChatMessages.*|TestGetChatMessages_.*|TestPatchChatMessage|TestChatMessageWithFile.*|TestDeleteChatQueuedMessage|TestPromoteChatQueuedMessage|TestQueuedMessageWithoutOverrideCapturesEnqueueTimeModel|TestSendMessage.*|TestSubsequentSendWithoutOverrideUsesPersistedModel|TestChatModelOverrides)$' -count=1passes (20 tests, 149 with subtests). The pre-commit hook passed (make gen, formatting, golangci-lint, slim build).