Repository navigation
refactor(coderd): share the chat prompt length check - #31020
Open
ibetitsmike wants to merge 1 commit into
Open
ibetitsmike wants to merge 1 commit into
ibetitsmike wants to merge 1 commit into
Conversation
Five prompt and instruction PUT handlers wrote the same 400 when the sanitized text is over the prompt byte limit. Share it in writePromptTooLongError.
Collaborator
Author
|
@codex review
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
ibetitsmike
marked this pull request as ready for review
October 19, 2026 22:48
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five
PUThandlers wrote the same400when the sanitized text is longer than the deployment's prompt byte limit: the deployment system prompt, the organization system prompt, plan mode instructions, the user custom prompt, and chat project instructions. This PR moves that check intoapi.writePromptTooLongError, which takes the sanitized text and each handler's message. It adds 16 lines and removes 28, and drops two comments that only said the limits match.Each handler still reads its body and calls
codersdk.SanitizePromptTextitself, because it keeps using the sanitized text. Moving the sanitize call into the helper would not remove any more lines: each call site would still need the sanitized value and the early return.Why it is safe: the messages, the detail text, and the limit are unchanged. I ran 6 mutants with
go test -overlay: reject a text of exactly the limit, change the message or the detail in the helper, and change the project instructions, custom prompt, and plan mode messages at their call sites. The tests fail on each.Review focus: the boolean result.
truemeans the helper wrote the400, and every call site returns on it.Validation: on
mainand on this branch,go test ./coderd -run '^(TestChatLimitsFromDeploymentConfig|TestChatProjectInstructions|TestChatSystemPrompt|TestChatPlanModeInstructions)$' -count=1passes (4 tests, 68 with subtests) andgo test ./enterprise/coderd -run '^(TestOrganizationChatSystemPrompt|TestChatProjectInstructionsUpdateOnlyRole|TestChatProjectInstructionsAudit)$' -count=1passes (3 tests, 14 with subtests). The pre-commit hook passed (make gen, formatting, golangci-lint, slim build).