Skip to content

refactor(coderd/x/chatd/chatdebug): delete the process-global step counters - #31008

Draft
ibetitsmike wants to merge 3 commits into
mike/chatdebug-db-step-numbersfrom
mike/chatdebug-delete-step-counters
Draft

ibetitsmike wants to merge 3 commits into
mike/chatdebug-db-step-numbersfrom
mike/chatdebug-delete-step-counters

Conversation

@ibetitsmike

@ibetitsmike ibetitsmike commented Oct 18, 2026 •

Copy link
Copy Markdown
Collaborator

Deletes chatdebug's process-global step counters: the stepCounters and runRefCounts maps, refCountMu, trackRunRef, releaseRunRef, nextStepNumber, syncStepCounter and CleanupStepCounter, the runtime.AddCleanup hook that ContextWithRun registered for every run context, and the two CleanupStepCounter calls in FinalizeRun. Since #31007 the database numbers steps, so no production code reads them.

Why it is safe: after #31007 no production code reads the counters. Production code only maintained them: ContextWithRun registered a reference for every run context and FinalizeRun called CleanupStepCounter, and this PR removes both. A search of coderd/ and enterprise/ for the deleted names finds nothing now. The deleted tests covered only the deleted code: TestNextStepNumber_Concurrent and TestSyncStepCounter_AdvancesCounter checked counter values, and the three garbage-collection tests in context_internal_test.go checked that a counter lives until the last RunContext for its run is collected. The 20 t.Cleanup(func() { CleanupStepCounter(runID) }) lines go with them. TestReuseStep_PreservesExistingHolder and TestBeginStepReuseStep stay. The FinalizeRun doc comment no longer mentions the counter.

Review focus: ContextWithRun is now a plain context.WithValue. Code that copies a RunContext, such as runnerDebugTurn.contextLocked, no longer affects anything, because no state is tied to the struct's lifetime.

Validation:

  • go test -race -count=1 -p 4 -parallel 4 ./coderd/x/chatd/chatdebug/... passes.
  • go test -count=1 -run Debug ./coderd/x/chatd/ (19 tests) passes, and the 25 chatd debug-run tests pass under -race (go test -race -run '^(TestActiveServer_ChatTurnDebugRun.*|TestRunnerDebugTurn.*|TestProposeChatTitle_DebugRun|TestArchiveChatDeletesDebugRuns|TestEditMessageDebugCleanup.*|TestQuickgen.*|TestMaybeGenerateChatTitle.*|TestPrepareManualTitleDebugRunCreateFailure)$' ./coderd/x/chatd/).
  • golangci-lint run --fix=false ./coderd/x/chatd/chatdebug/... reports 0 issues, and the pre-commit hook passed.

Stack

This stack deletes the stale debug-run sweep, then simplifies the chatdebug debug-run, stream wrapper and step numbering code, drops the indexes the sweep used, and last deletes a runner debug field that lost its only reader with the heartbeats. The debug-run and stream wrapper refactors each sit on a test-only layer that pins the behavior they keep.

  1. refactor(coderd): delete the chat debug run and step heartbeats #30988 Delete the chat debug run and step heartbeats
  2. refactor: delete chatdebug FinalizeStale and the stale threshold #30989 Delete FinalizeStale and the stale threshold
  3. refactor: delete the FinalizeStaleChatDebugRows query #30995 Delete the FinalizeStaleChatDebugRows query
  4. test(coderd/x/chatd): pin the debug runs that turns, titles and status labels record #30933 Pin the debug runs that turns, titles and status labels record
  5. refactor(coderd/x/chatd): create and finalize debug runs through one helper #30934 Create and finalize debug runs through one helper
  6. test(coderd/x/chatd/chatdebug): table the stream wrapper tests and cover their status rules #30980 Table the stream wrapper tests and cover their status rules
  7. refactor(coderd/x/chatd/chatdebug): share one finalize-once lifecycle between the stream wrappers #30981 Share one finalize-once lifecycle between the stream wrappers
  8. refactor(coderd): number chat debug steps in the database #31007 Number chat debug steps in the database
  9. This PR: Delete the process-global step counters
  10. chore(coderd/database): drop the chat debug stale-sweep indexes #31009 Drop the chat debug stale-sweep indexes
  11. refactor(coderd/x/chatd): drop the unused runnerCtx from the runner debug turn #31010 Drop the unused runnerCtx from the runner debug turn

Xum, an AI agent, opened this PR for @ibetitsmike and wrote this description.

…unters

The database numbers debug steps now, so nothing reads the per-run
counters. Delete stepCounters, runRefCounts, refCountMu, trackRunRef,
releaseRunRef, nextStepNumber, syncStepCounter and CleanupStepCounter,
the runtime.AddCleanup hook in ContextWithRun, the FinalizeRun cleanup
calls, and the tests of those helpers.
@ibetitsmike

Copy link
Copy Markdown
Collaborator Author

@codex review

Xum, an AI agent, requested this review for @ibetitsmike.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-18T20:55:00.295837Z 2d75929 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 208a2b8dbf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ibetitsmike

Copy link
Copy Markdown
Collaborator Author

@codex review

Xum, an AI agent, requested this review for @ibetitsmike.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 7bccdce589

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ibetitsmike

Copy link
Copy Markdown
Collaborator Author

@codex review

Xum, an AI agent, requested this review for @ibetitsmike.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 2d7592960b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant