Repository navigation
test(coderd/x/chatd): move the Anthropic guard unit test into chatsanitize - #30969
ibetitsmike wants to merge 2 commits into
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review
|
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Renames
coderd/x/chatd/anthropic_guard_test.gotocoderd/x/chatd/chatsanitize/anthropic_guard_test.goand moves the ten helpers onlyTestAnthropicProviderToolPreRequestGuarduses fromchatd_test.gointo it. The test now lives inchatsanitize, the package it tests.Why it is safe
This is a pure move. The only changed lines are the package clause (
chatd_testtochatsanitize_test) and thechatsanitizeimport thatchatd_test.gono longer needs. Git records the file as a rename (R056).chatd_test(git grep -nwper name), and none collides with a name inchatsanitize_test.-/+diff prints only the package clause and the removed import.git diff --color-moved=plainmarks all 128 moved helper lines as moved and leaves those 3 lines unmarked../coderd/x/chatd/chatsanitize/as before in./coderd/x/chatd/.Review focus
Confirm that the helpers arrived unchanged.
git diff -M --color-moved=plainshows it.Validation
go test ./coderd/x/chatd/chatsanitize/... -count=1and-run '^TestAnthropicProviderToolPreRequestGuard$' -v: pass, same 4 subtests.go vet ./coderd/x/chatd/ ./coderd/x/chatd/chatsanitize/: clean.Stack
This stack moves the Anthropic guard unit test into
chatsanitize, then deletes the guard escalation that can never repair a prompt.chatsanitize