refactor(codersdk): move chat settings client methods onto request helpers - #30962

Moves the 33 chat settings client methods in codersdk/chats.go onto the requestJSON and requestNoContent helpers from #30961: the deployment, organization, and user settings under /chats/config, and the organization model overrides. Each method drops its own request, status check, and decode block, so the file loses 283 lines.

Why it is safe: the script from #30961 did the conversion, and this diff is exactly its output. It rewrites a method only when its body ends in the standard block, with a zero value that matches the decoded type, and it keeps the HTTP method, path, body, and expected status. #30961 shows that the helpers return the same errors as the code they replace.

• The 776 tests in test files that call a chat client method (12 packages) pass here. With -coverpkg=./codersdk, every converted method's success path runs.
• Call-site mutants (go test -overlay) fail existing coderd tests: UpdateOrganizationChatModelOverride without a body (TestChatModelOverrides), DeleteUserChatCompactionThreshold sending GET (TestUserChatCompactionThresholds), GetChatAdvisorConfig expecting 201 (TestChatAdvisorConfig_GetDefault), and GetChatRetentionDays reading the debug retention path (TestChatRetentionDays).

Review focus: each hunk swaps one block for one call, so check the status argument against the deleted check. UpdateOrganizationChatModelOverride, UpdateUserChatCustomPrompt, and UpdateUserChatCompactionThreshold return a body with 200. The other updates expect 204.

Validation: go test ./codersdk -count=1 passes, golangci-lint run ./codersdk/ reports 0 issues, and the pre-commit hook passed.

Stack

This stack removes two unused chat exports from codersdk and moves 72 chat client methods in codersdk/chats.go onto two shared request helpers. Client behavior does not change.

1. refactor: remove unused chat exports from codersdk #30959 Remove unused chat exports from codersdk
2. test(codersdk): cover chat client request errors and options #30960 Cover chat client request errors and options
3. refactor(codersdk): add chat client request helpers #30961 Add chat client request helpers, for the project and model methods
4. refactor(codersdk): move chat settings client methods onto request helpers #30962 Move the chat settings methods onto the request helpers
5. refactor(codersdk): move chat client methods onto request helpers #30963 Move the chat methods onto the request helpers

Xum, an AI agent, opened this PR for @ibetitsmike and wrote this description.