Skip to content

fix(site): enlarge undersized Autocomplete clear and HelpPopover icon targets to 24px #30890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrifro wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

fix(site): enlarge undersized Autocomplete clear and HelpPopover icon targets to 24px #30890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f577f7
fix(site): enlarge undersized Autocomplete clear and HelpPopover icon…
chrifro Oct 16, 2026
61d2134
Merge branch 'main' into christin/deq-13-all-touch-targets-must-be-24…
chrifro Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion site/src/components/Autocomplete/Autocomplete.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ export function Autocomplete<TOption>({
handleClear(e);
}
}}
className="flex items-center justify-center size-5 rounded hover:bg-surface-secondary transition-colors cursor-pointer"
className="flex items-center justify-center size-6 rounded hover:bg-surface-secondary transition-colors cursor-pointer"
aria-label="Clear selection"
>
<XIcon className="size-4 text-content-secondary hover:text-content-primary" />
Expand Down
2 changes: 1 addition & 1 deletion site/src/components/HelpPopover/HelpPopover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export const HelpPopoverIconTrigger: React.FC<HelpPopoverIconTriggerProps> = ({
{...buttonProps}
type="button"
className={cn(
"flex items-center justify-center px-0 py-1",
"flex min-h-6 min-w-6 items-center justify-center p-0",
"border-0 border-none bg-transparent cursor-pointer text-inherit",
size === "small" ? "[&_svg]:size-3" : "[&_svg]:size-4",
hoverEffect &&
Expand Down
Loading