Repository navigation
Conversation
Chat-ID-scoped dbauthz methods read the chat through chats_expanded only to authorize it, and many of them run under the chat row lock. Following the workspace RBAC-in-context pattern, cache the chat's RBAC object (ID, owner, org; never ACLs, which change at runtime) on the context and authorize against it, falling back to the read on any failure or a different chat ID. Every chat-ID-scoped method whose read only served authorization uses it; UpdateChatACLByID keeps its read because it rejects sub-chats. ChatMachine.Update caches the object from the lock's own row, the chat HTTP middleware and the worker runner cache it up front, chat creation caches it from the inserted row, and acquisition caches it from the owner and organization GetChatWorkerAcquisitionCandidates now returns. Update callbacks pass tx.Ctx() to the store and helpers so their calls see the cached object. Generated by Coder Agents on behalf of @cstyan.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change in this PR is to allow reuse of a chat RBAC object by caching it on the Go context object, as we've done in a number of PRs earlier this year for other dbauthz calls. Chat-ID-scoped dbauthz methods read the chat through
chats_expandedjust ensure proper authorization by the caller, and many of these dbauthz calls execute queries that run under the chat row lock.Following the pattern from other PRs, we can cache the chat's RBAC object (which only contains ID, owner, org) on the context and authorize against it, falling back to the read on any failure or a different chat ID. Every chat-ID-scoped method whose read only served authorization uses it;
UpdateChatACLByIDkeeps its read because it rejects sub-chats.ChatMachine.Updatecaches the object from the lock's own row, the chat HTTP middleware and the worker runner cache it up front, chat creation caches it from the inserted row, and acquisition caches it from the owner and organizationGetChatWorkerAcquisitionCandidatesnow returns.Updatecallbacks passtx.Ctx()to the store and helpers so their calls see the cached object.Generated by Coder Agents on behalf of @cstyan.