Repository navigation
feat: add project skill API routes - #30827
Merged
Merged
Conversation
Contributor
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This was referenced Oct 15, 2026
ibetitsmike
added this pull request to stack #30842
October 15, 2026 12:14
This was referenced Oct 15, 2026
jaaydenh
marked this pull request as ready for review
October 16, 2026 09:39
ibetitsmike
approved these changes
Oct 16, 2026
Add experimental routes to list, create, read, update and delete skills on a chat project. Reading needs read on the project and writes need update; callers who lack the permission get a 404 like the project instructions routes. The handlers reuse the shared skill create and update path, map the per-project cap and name index to 409, and audit every write as a chat_project_skill. Add matching ExperimentalClient methods.
jaaydenh
added a commit
that referenced
this pull request
Oct 18, 2026
Adds the storage and authorization layer for chat project skills. The `skills` table already allows a `project_id` owner (migration 000621); this adds the queries for it and authorizes them through the parent chat project, the same way project instructions work. - New queries in `skills.sql`: insert, get by name, list metadata, update (COALESCE on description, content and enabled), delete, and `GetProjectSkillByIDForUpdate` for the shared update lock. - dbauthz checks `chat_project:read` on the project for reads and `chat_project:update` for writes. `authorizeChatProjectInstructions` became `authorizeChatProjectConfig`, shared by instructions and skills. `Skill.RBACObject()` still denies project rows so nothing reaches them without going through the project. - Audit: new `chat_project_skill` resource type (enum-only migration 000624), `AuditableChatProjectSkill`, and the usual diff/request/table/FriendlyString/AuditFilter wiring. The API that emits these entries comes in the next PR. Stack (merge top to bottom): - #30826 👈 - #30827 - #30838 - #30840 - #30854 - #30855 - #30856 - #30861 - #30880 - #30881 - #30882 - #30884
jaaydenh
force-pushed
the
chat-project-skills/api
branch
from
October 18, 2026 05:58
d1c3934 to
34c10cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds experimental routes for managing a chat project's skills under
/api/experimental/organizations/{organization}/chats/projects/{project}/skills: list, create, get, update (PATCH) and delete by skill name.The handlers reuse the shared skill create and update path from the personal and organization skill APIs. Reading needs
chat_project:readon the project and writing needschat_project:update; callers without access get 404, matching the project instructions routes. Duplicate names and the 100-skill-per-project cap return 409. Writes are audited aschat_project_skillwith the skill name as the target. The SDK gains the matchingExperimentalClientmethods.Stack (merge top to bottom):