Repository navigation
refactor(site/src/pages/AgentsPage): require always-passed settings and misc props - #29892
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
DanielleMaywood
force-pushed
the
nullability/settings-misc
branch
from
September 29, 2026 14:26
e512e57 to
e235dd0
Compare
jakehwll
approved these changes
Oct 6, 2026
DanielleMaywood
force-pushed
the
nullability/settings-misc
branch
from
October 6, 2026 08:07
e235dd0 to
d2f8c80
Compare
jaaydenh
approved these changes
Oct 6, 2026
…nd misc props Settings views, header buttons and small AgentsPage helpers declared props and parameters optional even though every production caller passes them. Their defaults, fallbacks and guards were dead. Make them required and delete the dead handling. ChimeButton and WebPushButton become controlled-only, dropping their internal chime state, internal useWebpushNotifications() call and fallback toggle branch. Stories now pass the required args.
DanielleMaywood
force-pushed
the
nullability/settings-misc
branch
from
October 6, 2026 11:12
d2f8c80 to
25bf69e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several AgentsPage settings views, header buttons and helpers declared props or parameters optional, but every production caller passes them.
AgentSettingsCompactionPagealways passes an array formodels(fromuseOrganizationChatModels) plus acompactionModelIDByOrganizationmap.AgentSettingsUserAgentsPagealways passesonRetryOverridesandisRetryingOverrides, andAgentSettingsPersonalSkillsPagealways passesisExportingAll.AgentCreatePagealways passesenabled/onToggletoChimeButtonandwebPush/onToggletoWebPushButton.AgentCreateFormalways passesonChangetoCompactOrgSelector, andAgentChatInputalways passesunsupportedProviderNamestoAgentSetupNotice(it defaults the value to[]itself).AgentsPageLayoutalways passesonToggleSearch.getUsableDefaultModelIDForOrganization,resolveCompactionThreshold,getModelDisplayNameandchangeColorare always called with non-null values, andUsageRingProgressalways getsseverity.These are now required, and the dead defaults,
?./&&guards and fallbacks are gone.ChimeButtonandWebPushButtonare now controlled-only: the internal chime state, the internaluseWebpushNotifications()call and the fallback subscribe/unsubscribe/toast branch are removed.getModelDisplayNamekeepsisUnsetModelRef, since that also treats""and the nil UUID as unset. The stories now pass the required args.ChimeButton.storiesswaps its click-to-toggle story for an explicitEnabledstory, so the two visual states stay covered. Left optional on purpose:aiGatewayDisabledandCompactIntegerField.error/disabled(skip list), andChatsSidebar.canManageAgentSettings, which is narrowed in #29889.Part of the AgentsPage nullability cleanup; see #29888 for the methodology. Dead slots for this cluster: 20 before, 1 after (the remaining one is
canManageAgentSettings, owned by #29889).This PR was generated by Coder Agents on behalf of @DanielleMaywood.